L1 Publisher: resend stuck tx and manage nonce #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BedrockSquirrel
force-pushed
the
matt/resend-stuck-l1-tx
branch
from
8948dab to
3d67f6b
Compare
BedrockSquirrel
force-pushed
the
matt/resend-stuck-l1-tx
branch
from
6c285c4 to
c43926e
Compare
tudor-malene
approved these changes
Sep 15, 2023
| // - This method will increment the wallet nonce only if the transaction is successfully broadcast | ||
| // - This method will continue to resend the tx using latest gas price until it is successfully broadcast or the L1 is unavailable/this service is shutdown | ||
| // - **ONLY** the L1 publisher service is publishing transactions for this wallet (to avoid nonce conflicts) | ||
| func (p *Publisher) publishTransaction(tx types.TxData) error { |
There was a problem hiding this comment.
as an improvement for the future, this could receive a cancelable context, so you can cancel the tx from the caller if circumstances change (for ex when it's time to build another rollup).
This could be a todo
There was a problem hiding this comment.
Yeah good shout, we should have that control, added todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
If a tx is stuck pending on sepolia it brings the whole network to a halt
What changes were made as part of this PR
Keep retrying stuck transactions with the same nonce but updated gas values.
The changes:
publishTransactionmethod takes responsibility for reverting the wallet nonce if something goes wrongPR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks